tech-story: [M3-9017] - Add MSW crud domains #11428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
requested review from
hkhalil-akamai and
pmakode-akamai
and removed request for
a team
abailly-akamai
commented
Dec 16, 2024
| been <strong>added</strong> to <EventLink event={e} to="entity" />. | ||
| </> | ||
| ); | ||
| }, |
There was a problem hiding this comment.
This fixes the case where there is no message associated with a DomainRecord added via importing a zone (most likely an APIv4 omission)
| @@ -28,7 +28,7 @@ const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms)); | |||
| export const queueEvents = (props: QueuedEvents): Promise<void> => { | |||
| const { event, mockState, sequence } = props; | |||
|
|
|||
| const initialDelay = 7500; | |||
| const initialDelay = 2500; | |||
There was a problem hiding this comment.
queuing events quicker since we shouldn't have to wait that much when mocking
Cloud Manager UI test results🎉 466 passing tests on test run #1 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Straight forward PR to add domains to CRUD mode (including seeds)
Changes 🔄
domainsCRUD modedomainsseedHow to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅